Skip to content

Add find_element and get_elements_by_tagname methods #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vargonis
Copy link

  1. It is proposed that find_element and get_elements_by_tagname accept, besides an XMLElement, also an XMLDocument as first argument.
  2. A method find_element(x, ns::Vector{<:AbstractString}) is implemented. It just folds find_element over the vector of abstract strings.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (2a5e3a6) to head (ef29d7f).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/document.jl 0.00% 4 Missing ⚠️
src/nodes.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   76.97%   74.52%   -2.46%     
==========================================
  Files           6        6              
  Lines         152      157       +5     
==========================================
  Hits          117      117              
- Misses         35       40       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@omus
Copy link
Member

omus commented Feb 24, 2020

Needs tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants